feat: add support for analysis mode #15
Merged
+3,764
−2,979
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
not-matthias
force-pushed
the
cod-1710-instrument-hooks-support-new-analysis-mode
branch
4 times, most recently
from
5737ac4 to
c4f95c0
Compare
Copilot finished reviewing on behalf of
not-matthias
November 21, 2025 15:22
There was a problem hiding this comment.
Pull request overview
This PR adds support for a new "analysis" integration mode, allowing the instrumentation hooks to operate in three distinct modes: Valgrind, Perf, and Analysis. The implementation refactors existing code to use a common helper for FIFO-based instruments.
- Introduces the
IntegrationModeenum and related protocol commands for mode detection - Creates a generic
FifoInstrumenthelper that validates the integration mode during initialization - Refactors
PerfInstrumentto use the new helper and moves related code torunner_fifo.zig
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| src/shared.zig | Adds IntegrationMode enum and new Command variants for integration mode queries |
| src/runner_fifo.zig | New file containing refactored FIFO communication logic from perf.zig with mode detection |
| src/instruments/helper.zig | New generic FifoInstrument function that creates mode-validated instrument implementations |
| src/instruments/perf.zig | Refactored to use FifoInstrument helper, significantly reduced code |
| src/instruments/analysis.zig | New analysis instrument using the FifoInstrument helper |
| src/instruments/valgrind.zig | Updated init to return error when not instrumented for consistency |
| src/instruments/root.zig | Updated to support analysis mode with proper initialization order and delegation |
| src/c.zig | Removed protocol version validation logic (moved to runner_fifo.zig) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
not-matthias
force-pushed
the
cod-1710-instrument-hooks-support-new-analysis-mode
branch
from
4ecb2f7 to
d673228
Compare
not-matthias
force-pushed
the
cod-1710-instrument-hooks-support-new-analysis-mode
branch
from
d673228 to
a19e8c3
Compare
not-matthias
force-pushed
the
cod-1710-instrument-hooks-support-new-analysis-mode
branch
2 times, most recently
from
3224a77 to
a36c4d7
Compare
not-matthias
force-pushed
the
cod-1710-instrument-hooks-support-new-analysis-mode
branch
from
a36c4d7 to
dfad349
Compare
not-matthias
force-pushed
the
cod-1710-instrument-hooks-support-new-analysis-mode
branch
from
dfad349 to
075ad83
Compare
not-matthias
deleted the
cod-1710-instrument-hooks-support-new-analysis-mode
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.